From: Chris Fulljames <christianfulljames@gmail.com>
Date: Tue, 18 Feb 2025 23:57:38 +0000 (-0500)
Subject: Handle all links, not just navbar
X-Git-Url: https://littlesong.place/gitweb/?a=commitdiff_plain;h=1bfeb5825a12af4ae4e9228da350b0e93460e3e2;p=littlesongplace.git

Handle all links, not just navbar
---

diff --git a/templates/base.html b/templates/base.html
index f14ef47..69b1a9d 100644
--- a/templates/base.html
+++ b/templates/base.html
@@ -11,18 +11,25 @@
         {% endblock %}
         <script>
             document.addEventListener("click", (event) => {
-                // TODO - what links do we actually want to match?  Use URL?
-                if (!event.target.matches(".navbar a")) {
+                // Handle all clicks on links
+                if (!event.target.matches("a")) {
                     return;
                 }
+
+                // Only intercept links to other pages on the site
+                var targetUrl = new URL(event.target.href);
+                var currentUrl = new URL(window.location.href);
+                if (targetUrl.origin !== currentUrl.origin) {
+                    return;  // Link to external site
+                }
+
                 event.preventDefault();
 
                 // Add AJAX type specifier to URL params
-                var url = new URL(event.target.href);
-                url.searchParams.set("request-type", "ajax")
+                targetUrl.searchParams.set("request-type", "ajax")
 
                 // Update HTML
-                getPageAjax(url);
+                getPageAjax(targetUrl);
             });
             async function getPageAjax(url) {
                 fetch(url, {redirect: "follow"}).then(async (response) => {
diff --git a/todo.txt b/todo.txt
index e93e883..a6b7902 100644
--- a/todo.txt
+++ b/todo.txt
@@ -2,7 +2,6 @@ NOW
 - AJAX pages so songs can play during navigation
     - Forms
     - Back (history stack)
-    - Other on-site links (songs, profiles, tags, etc.)
     - Update page colors
 - Break up main.py, test_offline.py
 - Pinned profile playlists